Re: [PATCH v3] net: tun: set tun->dev->addr_len during TUNSETLINK processing

From: Eric Dumazet
Date: Tue Apr 06 2021 - 16:32:10 EST




On 4/6/21 7:45 PM, Phillip Potter wrote:
> When changing type with TUNSETLINK ioctl command, set tun->dev->addr_len
> to match the appropriate type, using new tun_get_addr_len utility function
> which returns appropriate address length for given type. Fixes a
> KMSAN-found uninit-value bug reported by syzbot at:
> https://syzkaller.appspot.com/bug?id=0766d38c656abeace60621896d705743aeefed51
>
> Reported-by: syzbot+001516d86dbe88862cec@xxxxxxxxxxxxxxxxxxxxxxxxx
> Diagnosed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> ---

SGTM, thanks a lot.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>