Re: [PATCH v11 0/4] misc: Add Synopsys DesignWare xData IP driver

From: Greg Kroah-Hartman
Date: Tue Apr 06 2021 - 13:34:06 EST


On Tue, Apr 06, 2021 at 07:26:45PM +0200, Gustavo Pimentel wrote:
> This patch series adds a new driver called xData-pcie for the Synopsys
> DesignWare PCIe prototype.
>
> The driver configures and enables the Synopsys DesignWare PCIe traffic
> generator IP inside of prototype Endpoint which will generate upstream
> and downstream PCIe traffic. This allows to quickly test the PCIe link
> throughput speed and check is the prototype solution has some limitation
> or not.
>
> Changes:
> V2: Rework driver according to Greg Kroah-Hartman' feedback
> - Replace module parameter by sysfs use.
> - Replace bit fields structure with macros and masks use.
> - Removed SET() and GET() macros by the writel() and readl().
> - Removed some noisy info messages.
> V3: Fixed issues detected while running on 64 bits platforms
> Rebased patches on top of v5.11-rc1 version
> V4: Rework driver according to Greg Kroah-Hartman' feedback
> - Add the ABI doc related to the sysfs implemented on this driver
> V5: Rework driver accordingly to Leon Romanovsky' feedback
> - Removed "default n" on Kconfig
> Rework driver accordingly to Krzysztof Wilczyński' feedback
> - Added some explanatory comments for some steps
> - Added some bit defines instead of magic numbers
> V6: Rework driver according to Greg Kroah-Hartman' feedback
> - Squashed patches #2 and #3
> - Removed units (MB/s) on the sys file
> - Reduced mutex scope on the functions called by sysfs
> Rework driver accordingly to Krzysztof Wilczyński' feedback
> - Fix typo "DesignWare"
> V7: Rework driver according to Greg Kroah-Hartman' feedback
> - Created a sub device (misc device) that will be associated with the PCI driver
> - sysfs group is now associated with the misc drivers instead of the PCI driver
> V8: Rework driver according to Greg Kroah-Hartman' feedback
> - Added more detail to the version changes on the cover letter
> - Squashed patches #1 and #2
> - Removed struct device from the dw_xdata_pcie structure
> - Replaced the pci_*() use by dev_*()
> - Added free call for the misc driver name allocation
> - Added reference counting
> - Removed snps_edda_data structure and their usage
> Rebased patches on top of v5.12-rc4 version
> V9: Squashed temporary development patch #5 into the driver patch #1
> V10: Reworked the write_store() and read_store() to validate the input using kstrtobool()
> Removed stop_store()
> Update ABI documentation accordingly
> V11: Fixed the documentation based on the warnings detected by Stephen Rothwell

As mentioned on the other thread, I can't take these as I took your v10
into my public tree. Please send fixes on top of that.

thanks,

greg k-h