Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

[Chun-Kuang Hu]

Andrew Lunn <andrew@xxxxxxx> 於 2021年4月7日 週三 上午12:02寫道：
>
> On Tue, Apr 06, 2021 at 11:47:08PM +0800, Chun-Kuang Hu wrote:
> > Hi, Qingfang:
> >
> > DENG Qingfang <dqfext@xxxxxxxxx> 於 2021年4月6日 週二 下午10:19寫道：
> > >
> > > Add support for MediaTek PHYs found in MT7530 and MT7531 switches.
> > > The initialization procedure is from the vendor driver, but due to lack
> > > of documentation, the function of some register values remains unknown.
> > >
> > > Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx>
> > > ---
> > >  drivers/net/phy/Kconfig    |   5 ++
> > >  drivers/net/phy/Makefile   |   1 +
> > >  drivers/net/phy/mediatek.c | 109 +++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 115 insertions(+)
> > >  create mode 100644 drivers/net/phy/mediatek.c
> > >
> > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> > > index a615b3660b05..edd858cec9ec 100644
> > > --- a/drivers/net/phy/Kconfig
> > > +++ b/drivers/net/phy/Kconfig
> > > @@ -207,6 +207,11 @@ config MARVELL_88X2222_PHY
> > >           Support for the Marvell 88X2222 Dual-port Multi-speed Ethernet
> > >           Transceiver.
> > >
> > > +config MEDIATEK_PHY
> >
> > There are many Mediatek phy drivers in [1], so use a specific name.
>
> Those are generic PHY drivers, where as this patch is add a PHY
> driver. The naming used in this patch is consistent with other PHY
> drivers. So i'm happy with this patch in this respect.
>
> PHY drivers have been around a lot longer than generic PHY drivers. So
> i would actually say the generic PHY driver naming should make it
> clear they are generic PHYs, not PHYs.
>

OK, so just ignore my comment.

> But lets not bike shed about this too much.
>
>       Andrew