Re: [PATCH v2 02/13] intel_gna: add component of hardware operation

[Maciej Kwapulinski]

Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:

> On Wed, Mar 24, 2021 at 8:38 PM Maciej Kwapulinski
> <maciej.kwapulinski@xxxxxxxxxxxxxxx> wrote:
>> +#define gna_reg_write(addr, offset, value)     writel((value), (addr) + (offset))
>
> No point And make them functions, not macros.
>
>> +
>> +#endif // __GNA_HW_H__
>> --
>> 2.28.0
>>

Andy, Thank You for all Your comments on these two patches.

I'm starting to work with them. Just as with v1 patch series, I'll
get back to You in case of any questions
Regards,
Maciej