Re: [PATCH v3 2/3] dt-bindings: touchscreen: Add HY46XX bindings

[Giulio Benetti]

Hi Jonathan,

On 4/6/21 3:37 PM, Jonathan Neuschäfer wrote:
> In the binding:
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - hycon,hycon-hy4613
> > +      - hycon,hycon-hy4614
> > +      - hycon,hycon-hy4621
> > +      - hycon,hycon-hy4623
> > +      - hycon,hycon-hy4633
> > +      - hycon,hycon-hy4635
>
> In the example:
> > +      hycon-hy4633@1c {
> > +        compatible = "hycon,hy4633";
> > +        reg = <0x1c>;
> > +        interrupt-parent = <&gpio2>;
> > +        interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
> > +        reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>;
> > +      };
>
>
> Rob's devicetree lint bot detected the mismatch in compatible string
> here.
>
> I personally think 'hycon,hy4633' looks better than 'hycon,hycon-hy4633',
> because it isn't so redundant.

Thank you, I've realized it after submitting patches and waited for 
other comments. I've already fixed it the way you've pointed.

Kind regards
--
Giulio Benetti
Benetti Engineering sas
> Best regards,
> Jonathan Neuschäfer