Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature

From: Jens Wiklander
Date: Tue Apr 06 2021 - 08:30:49 EST


Hi Heiko,

[+Arnd]

On Tue, Apr 6, 2021 at 12:38 PM Heiko Thiery <heiko.thiery@xxxxxxxxx> wrote:
>
> Hi Jens,
>
> Am Di., 30. März 2021 um 10:26 Uhr schrieb Jens Wiklander
> <jens.wiklander@xxxxxxxxxx>:
> >
> > On Thu, Mar 25, 2021 at 12:06:01PM +0800, Jisheng Zhang wrote:
> > > If build kernel without "O=dir", below error will be seen:
> > >
> > > In file included from drivers/tee/optee/optee_trace.h:67,
> > > from drivers/tee/optee/call.c:18:
> > > ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
> > > 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> > > | ^
> > > compilation terminated.
> > >
> > > Fix it by adding below line to Makefile:
> > > CFLAGS_call.o := -I$(src)
> > >
> > > Tested with and without "O=dir", both can build successfully.
> > >
> > > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx>
> >
> > I've picked up this.
>
> For what tree did you pick this? I still see this build failure on the
> latest next tree (next-20210401).

The next tree hasn't been updated since 1th of April so it's not
unexpected. The fix is supposed to be on its way to
https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=arm/drivers
, I can't see it there yet though.

Cheers,
Jens