Re: [PATCH v4 3/7] regulator: IRQ based event/error notification helpers

From: Matti Vaittinen
Date: Tue Apr 06 2021 - 06:57:34 EST



On Tue, 2021-04-06 at 18:27 +0800, kernel test robot wrote:
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/kernel.h:16,
> from arch/x86/include/asm/percpu.h:27,
> from arch/x86/include/asm/current.h:6,
> from include/linux/sched.h:12,
> from include/linux/ratelimit.h:6,
> from include/linux/dev_printk.h:16,
> from include/linux/device.h:15,
> from drivers/regulator/irq_helpers.c:10:
> drivers/regulator/irq_helpers.c: In function 'die_loudly':
> > > drivers/regulator/irq_helpers.c:46:11: error: expected ')' before
> > > 'msg'
> 46 | pr_emerg(msg);
> | ^~~
> include/linux/printk.h:301:21: note: in definition of macro
> 'pr_fmt'
> 301 | #define pr_fmt(fmt) fmt
> | ^~~
> drivers/regulator/irq_helpers.c:46:2: note: in expansion of macro
> 'pr_emerg'
> 46 | pr_emerg(msg);
> | ^~~~~~~~

Ouch. Feeling stupid now.
I am sorry for the hassle folks. I'll fix this ASAP and resend.

>
> vim +46 drivers/regulator/irq_helpers.c
>
> 43
> 44 static void die_loudly(const char *msg)
> 45 {
> > 46 pr_emerg(msg);
> 47 BUG();
> 48 }
> 49

Best Regards
Matti Vaittinen