RE: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

From: Pho Tran
Date: Tue Apr 06 2021 - 05:25:22 EST


Hi Greg!
Should I send the Patch with new version (PATCH v8) or keep version of the Patch is v7?

-----Original Message-----
From: 'Greg KH' <gregkh@xxxxxxxxxxxxxxxxxxx>
Sent: Tuesday, April 6, 2021 4:11 PM
To: Pho Tran <Pho.Tran@xxxxxxxxxx>
Cc: 'Pho Tran' <photranvan0712@xxxxxxxxx>; 'johan@xxxxxxxxxx' <johan@xxxxxxxxxx>; 'linux-usb@xxxxxxxxxxxxxxx' <linux-usb@xxxxxxxxxxxxxxx>; 'linux-kernel@xxxxxxxxxxxxxxx' <linux-kernel@xxxxxxxxxxxxxxx>; Hung Nguyen <Hung.Nguyen@xxxxxxxxxx>; Tung Pham <Tung.Pham@xxxxxxxxxx>; 'Kernel test robot' <lkp@xxxxxxxxx>
Subject: Re: [PATCH v7] USB: serial: cp210x: Add support for GPIOs on CP2108

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Tue, Apr 06, 2021 at 08:17:42AM +0000, Pho Tran wrote:
> Hi Greg!
> I am grateful for your promptly reply!
> Yesterday, I got the response from the kernel test robot with this message:
> " If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>".
> It's a reason why I added "Reported-by: kernel test robot <lkp@xxxxxxxxx>"
> to my new Patch.
> Could you tell me what I need to do in the next step to submit this patch to the kernel mainline?
> Once again, Thank you a lot!

If you fixed this as an add-on patch, yes it would belong in the
reported-by: But as you are just fixing this up to a patch that has not been accepted yet, all you need to do is write it in the "what changed from the previous version" section of the changelog, below the --- line.

thanks,

greg k-h