Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

[yumeng]

在 2021/4/2 18:22, Herbert Xu 写道:
> On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote:
> > I think it is not a real bug, and soft fallback setkey can always catch the
> > error.
> > But our original intention was to make it don't go to 'xxx_set_pub_key'
> > when the key is null, and it can return an error earlier.
> > But maybe it is not good.
>
> It might make sense to check them twice if you were touching them
> directly, e.g., poking inside the key.  However, it appears that
> your driver simply palms off the key to rsa_helper.c which should
> check the key/keylen too so I think there is no need for this patch
> for now.
>
> Thanks,

OK, thank you.