Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register

[Greg KH]

On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote:
> Added a sysfs entry to support writing to the offset register on page1.
> This register is used to calibrate the chip canceling offset errors in the
> current ADC. This means that, over time, reading the IAD register will not
> return the correct current measurement, it will have an offset. Writing to
> the offset register if the two's complement of the current register while
> passing zero current to the load will calibrate the measurements. This
> change was tested on real hardware and it was able to calibrate the chip
> correctly.
> 
> Signed-off-by: Luiz Sampaio <sampaio.ime@xxxxxxxxx>
> ---
>  Documentation/w1/slaves/w1_ds2438.rst | 11 +++++-
>  drivers/w1/slaves/w1_ds2438.c         | 49 +++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 1 deletion(-)

In this, and the previous patch, you added new sysfs files, but no
update to Documentation/ABI/ for them.  Please fix that up.

thanks,

greg k-h