Re: [PATCH] nfc: s3fwrn5: remove unnecessary label

From: Krzysztof Kozlowski
Date: Fri Apr 02 2021 - 12:28:33 EST


On 02/04/2021 14:15, samirweng1979 wrote:
> From: wengjianfeng <wengjianfeng@xxxxxxxxxx>
>
> In function s3fwrn5_nci_post_setup, The variable ret is assigned to 0,
> then goto out label, but just return ret in out label, so we use
> return 0 to replace it. and other goto sentences are similar, we use
> return sentences to replace it and delete out label.

The message is difficult to understand - you created one long sentence
with mixing tenses and subjects. "The" starts capital in the middle of
sentence but "and" starts after full stop.

Please rephrase it.

The code itself looks ok.

Best regards,
Krzysztof