Re: [PATCH] dma-mapping: make map_benchmark compile into module

From: Christoph Hellwig
Date: Fri Apr 02 2021 - 10:45:02 EST


On Wed, Mar 24, 2021 at 07:33:23AM +0000, Song Bao Hua (Barry Song) wrote:
> The requirement comes from an colleague who is frequently changing
> the map-bench code for some customized test purpose. and he doesn't
> want to build kernel image and reboot every time. So I moved the
> requirement to Tao Tian.
>
> Right now, kthread_bind() is exported, kthread_bind_mask() seems
> to be a little bit "internal" as you said, maybe a wrapper like
> kthread_bind_node() won't be that "internal", comparing to exposing
> the cpumask?

I really don't think we should be exporting more low-level kthread
APIs. Especially as we've been trying to get most users off the
kthread API and to workqueues instead.