Re: [PATCH 3/9] sched: Trivial core scheduling cookie management

[Peter Zijlstra]

On Thu, Apr 01, 2021 at 01:04:58PM -0700, Josh Don wrote:
> > +/*
> > + * sched_core_update_cookie - Common helper to update a task's core cookie. This
> > + * updates the selected cookie field.
> > + * @p: The task whose cookie should be updated.
> > + * @cookie: The new cookie.
> > + * @cookie_type: The cookie field to which the cookie corresponds.
> 
> No cookie_type in this patch (or cookie fields). Also might want to
> call out that the caller is responsible for put'ing the return value.

Lol, I don't think I've even seen the comment. Yes that needs more than
a rewording.