Re: [PATCH v2] ext4: Fix ext4_error_err save negative errno into superblock

[Andreas Dilger]

On Apr 1, 2021, at 1:40 AM, Ye Bin <yebin10@xxxxxxxxxx> wrote:
> 
> As read_mmp_block return 1 when failed. read_mmp_block return -EIO when buffer
> isn't uptodate.

Thank you for this second patch.  Unfortunately, the commit message
is still confusing/incorrect because it references read_mmp_block()
in the first usage but is actually changing write_mmp_block().

With that change you could add a Reviewed-by label from me.

Cheers, Andreas

> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and
> drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@xxxxxxxxxx>
> Signed-off-by: Ye Bin <yebin10@xxxxxxxxxx>
> ---
> fs/ext4/mmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 795c3ff2907c..68fbeedd627b 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
> 	wait_on_buffer(bh);
> 	sb_end_write(sb);
> 	if (unlikely(!buffer_uptodate(bh)))
> -		return 1;
> +		return -EIO;
> 
> 	return 0;
> }
> --
> 2.25.4
> 


Cheers, Andreas

Attachment: signature.asc
Description: Message signed with OpenPGP