Re: [PATCH] mm: page_owner: use kstrtobool() to parse bool option

From: Matthew Wilcox
Date: Thu Apr 01 2021 - 17:44:22 EST


On Thu, Apr 01, 2021 at 10:09:09PM +0100, Sergei Trofimovich wrote:
> I tried to use page_owner=1 for a while noticed too late it had
> no effect as opposed to similar init_on_alloc=1 (these work).
>
> Let's make them consistent.
>
> The change decreses binary size slightly:
> text data bss dec hex filename
> 12408 321 17 12746 31ca mm/page_owner.o.before
> 12320 321 17 12658 3172 mm/page_owner.o.after
>
> CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> CC: linux-mm@xxxxxxxxx
> Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Seems to me there are a few other places that could benefit from this.

kmemleak_boot_config()
early_kasan_flag()
early_kasan_flag_stacktrace()
nonx32_setup()

maybe others? grep is our friend.