Re: [GIT PULL] ftrace: Check if pages were allocated before calling free_pages()

From: Steven Rostedt
Date: Thu Apr 01 2021 - 16:25:27 EST


On Thu, 1 Apr 2021 16:07:10 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > @@ -6231,7 +6231,8 @@ static int ftrace_process_locs(struct module *mod,
> > if (!addr)
> > continue;
> >
> > - if (pg->index == pg->size) {
> > + end_offset = (pg->index+1) * sizeof(pg->records[0]);
> > + if (end_offset < PAGE_SIZE << pg->order) {
>
> I believe that needs to be:
>
> if (end_offset >= PAGE_SIZE << pg->order) {
>
> But as you said, you didn't test it. I'll look to see what else needs to be
> fixed.

After making the above change, it appears to work.

Want to give me your "Signed-off-by"?

-- Steve