Re: [External] Re: [PATCH v2] writeback: fix obtain a reference to a freeing memcg css

[Muchun Song]

On Thu, Apr 1, 2021 at 10:37 PM Michal Hocko <mhocko@xxxxxxxx> wrote:
>
> On Thu 01-04-21 21:59:13, Muchun Song wrote:
> > On Thu, Apr 1, 2021 at 6:26 PM Michal Hocko <mhocko@xxxxxxxx> wrote:
> [...]
> > > Even if the css ref count is not really necessary it shouldn't cause any
> > > harm and it makes the code easier to understand. At least a comment
> > > explaining why that is not necessary would be required without it
> >
> > OK. I will add a comment here to explain why we need to hold a
> > ref.
>
> I do not think this is necessary. Taking the reference is a standard
> way and I am not sure it requires a comment. I meant to say that not
> having a reference should really have a comment explaining why.

Very Sorry. I got it wrong, thank you for further explanation.

>
> Thanks!
> --
> Michal Hocko
> SUSE Labs