Re: [PATCH] ext4: Delete redundant uptodate check for buffer

From: Ritesh Harjani
Date: Thu Apr 01 2021 - 14:04:02 EST


On 21/04/01 03:03PM, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@xxxxxxxxxx>
>
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
>
> Cc: "Theodore Ts'o" <tytso@xxxxxxx>
> Cc: Andreas Dilger <adilger.kernel@xxxxxxxxx>
> Signed-off-by: Yang Guo <guoyang2@xxxxxxxxxx>
> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
> ---
> fs/ext4/inode.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Thanks for the patch. Changes looks good and trivial.

Feel free to add -
Reviewed-by: Ritesh Harjani <ritesh.list@xxxxxxxxx>