Re: [PATCH v4 2/2] Adding i2c-cp2615: i2c support for Silicon Labs' CP2615 Digital Audio Bridge

From: kernel test robot
Date: Thu Apr 01 2021 - 02:13:23 EST

Hi "Bence,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on linux/master linus/master v5.12-rc5 next-20210331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Bence-Cs-k-s/Adding-i2c-cp2615-i2c-support-for-Silicon-Labs-CP2615-Digital-Audio/20210401-030413
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: riscv-randconfig-r032-20210401 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/0day-ci/linux/commit/f7bd7e90cde56628778fb121154088af095d3fa8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bence-Cs-k-s/Adding-i2c-cp2615-i2c-support-for-Silicon-Labs-CP2615-Digital-Audio/20210401-030413
git checkout f7bd7e90cde56628778fb121154088af095d3fa8
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-cp2615.c:323:1: warning: declaration specifier missing, defaulting to 'int'
MODULE_DEVICE_TABLE(usb, id_table);
^
int
>> drivers/i2c/busses/i2c-cp2615.c:323:21: error: a parameter list without types is only allowed in a function definition
MODULE_DEVICE_TABLE(usb, id_table);
^
drivers/i2c/busses/i2c-cp2615.c:332:1: warning: declaration specifier missing, defaulting to 'int'
module_usb_driver(cp2615_i2c_driver);
^
include/linux/usb.h:1305:2: note: expanded from macro 'module_usb_driver'
module_driver(__usb_driver, usb_register, \
^
include/linux/device/driver.h:262:3: note: expanded from macro 'module_driver'
} \
^
drivers/i2c/busses/i2c-cp2615.c:332:1: error: a parameter list without types is only allowed in a function definition
include/linux/usb.h:1305:2: note: expanded from macro 'module_usb_driver'
module_driver(__usb_driver, usb_register, \
^
include/linux/device/driver.h:263:13: note: expanded from macro 'module_driver'
module_init(__driver##_init); \
^
<scratch space>:203:1: note: expanded from here
cp2615_i2c_driver_init
^
drivers/i2c/busses/i2c-cp2615.c:332:1: warning: declaration specifier missing, defaulting to 'int'
include/linux/usb.h:1305:2: note: expanded from macro 'module_usb_driver'
module_driver(__usb_driver, usb_register, \
^
include/linux/device/driver.h:267:3: note: expanded from macro 'module_driver'
} \
^
drivers/i2c/busses/i2c-cp2615.c:332:1: error: a parameter list without types is only allowed in a function definition
include/linux/usb.h:1305:2: note: expanded from macro 'module_usb_driver'
module_driver(__usb_driver, usb_register, \
^
include/linux/device/driver.h:268:13: note: expanded from macro 'module_driver'
module_exit(__driver##_exit);
^
<scratch space>:205:1: note: expanded from here
cp2615_i2c_driver_exit
^
>> drivers/i2c/busses/i2c-cp2615.c:334:15: error: expected parameter declarator
MODULE_AUTHOR("Bence Csókás <bence98@xxxxxxxxxx>");
^
>> drivers/i2c/busses/i2c-cp2615.c:334:15: error: expected ')'
drivers/i2c/busses/i2c-cp2615.c:334:14: note: to match this '('
MODULE_AUTHOR("Bence Csókás <bence98@xxxxxxxxxx>");
^
drivers/i2c/busses/i2c-cp2615.c:334:1: warning: declaration specifier missing, defaulting to 'int'
MODULE_AUTHOR("Bence Csókás <bence98@xxxxxxxxxx>");
^
int
>> drivers/i2c/busses/i2c-cp2615.c:334:14: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
MODULE_AUTHOR("Bence Csókás <bence98@xxxxxxxxxx>");
^
void
drivers/i2c/busses/i2c-cp2615.c:335:20: error: expected parameter declarator
MODULE_DESCRIPTION("CP2615 I2C bus driver");
^
drivers/i2c/busses/i2c-cp2615.c:335:20: error: expected ')'
drivers/i2c/busses/i2c-cp2615.c:335:19: note: to match this '('
MODULE_DESCRIPTION("CP2615 I2C bus driver");
^
drivers/i2c/busses/i2c-cp2615.c:335:1: warning: declaration specifier missing, defaulting to 'int'
MODULE_DESCRIPTION("CP2615 I2C bus driver");
^
int
drivers/i2c/busses/i2c-cp2615.c:335:19: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
MODULE_DESCRIPTION("CP2615 I2C bus driver");
^
void
drivers/i2c/busses/i2c-cp2615.c:336:16: error: expected parameter declarator
MODULE_LICENSE("GPL");
^
drivers/i2c/busses/i2c-cp2615.c:336:16: error: expected ')'
drivers/i2c/busses/i2c-cp2615.c:336:15: note: to match this '('
MODULE_LICENSE("GPL");
^
drivers/i2c/busses/i2c-cp2615.c:336:1: warning: declaration specifier missing, defaulting to 'int'
MODULE_LICENSE("GPL");
^
int
drivers/i2c/busses/i2c-cp2615.c:336:15: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
MODULE_LICENSE("GPL");
^
void
6 warnings and 12 errors generated.


vim +323 drivers/i2c/busses/i2c-cp2615.c

322
> 323 MODULE_DEVICE_TABLE(usb, id_table);
324
325 static struct usb_driver cp2615_i2c_driver = {
326 .name = "i2c-cp2615",
327 .probe = cp2615_i2c_probe,
328 .disconnect = cp2615_i2c_remove,
329 .id_table = id_table,
330 };
331
332 module_usb_driver(cp2615_i2c_driver);
333
> 334 MODULE_AUTHOR("Bence Csókás <bence98@xxxxxxxxxx>");

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip