[PATCH v3] cxl: Make loop variable be 'i' instead of 'j'

From: Konrad Rzeszutek Wilk
Date: Fri Feb 26 2021 - 17:22:53 EST


.. otherwise people spend extra cycles looking for the
inner loop and wondering 'why j'?

This was an oversight when initial work was rebased
so let's fix it here.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
v1: Initial posting
v2: Fix per Dan's request
v3: Duh, don't initialize i in the loop, but do it outside of it.
---
drivers/cxl/mem.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
index 244cb7d89678..e7246e585e62 100644
--- a/drivers/cxl/mem.c
+++ b/drivers/cxl/mem.c
@@ -698,7 +698,7 @@ static int cxl_query_cmd(struct cxl_memdev *cxlmd,
struct device *dev = &cxlmd->dev;
struct cxl_mem_command *cmd;
u32 n_commands;
- int j = 0;
+ int i;

dev_dbg(dev, "Query IOCTL\n");

@@ -713,13 +713,14 @@ static int cxl_query_cmd(struct cxl_memdev *cxlmd,
* otherwise, return max(n_commands, total commands) cxl_command_info
* structures.
*/
+ i = 0;
cxl_for_each_cmd(cmd) {
const struct cxl_command_info *info = &cmd->info;

- if (copy_to_user(&q->commands[j++], info, sizeof(*info)))
+ if (copy_to_user(&q->commands[i++], info, sizeof(*info)))
return -EFAULT;

- if (j == n_commands)
+ if (i == n_commands)
break;
}

--
2.29.2