Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

From: Robert Richter
Date: Fri Feb 26 2021 - 10:14:12 EST


On 25.02.21 15:37:09, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Compile-testing these drivers is currently broken. Enabling
> it causes a couple of build failures though:
>
> drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration]
> drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration]
>
> Fix them with the obvious one-line changes.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Robert Richter <rric@xxxxxxxxxx>

> ---
> drivers/pci/controller/pci-thunder-ecam.c | 2 +-
> drivers/pci/controller/pci-thunder-pem.c | 13 +++++++------
> drivers/pci/pci.h | 6 ++++++
> 3 files changed, 14 insertions(+), 7 deletions(-)