Re: [PATCH] riscv: Improve KASAN_VMALLOC support

From: kernel test robot
Date: Fri Feb 26 2021 - 09:37:36 EST


Hi Alexandre,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20210226]
[cannot apply to linus/master v5.11 v5.11-rc7 v5.11-rc6 v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Alexandre-Ghiti/riscv-Improve-KASAN_VMALLOC-support/20210226-210227
base: d01f2f7e35573049673b71e18be7abfe3f80323f
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/0b62a4a56a372fe72012b7a056562e1e04d7030f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alexandre-Ghiti/riscv-Improve-KASAN_VMALLOC-support/20210226-210227
git checkout 0b62a4a56a372fe72012b7a056562e1e04d7030f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> arch/riscv/mm/kasan_init.c:146:13: warning: no previous prototype for 'kasan_shallow_populate_pgd' [-Wmissing-prototypes]
146 | void __init kasan_shallow_populate_pgd(unsigned long vaddr, unsigned long end)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/riscv/mm/kasan_init.c:161:13: warning: no previous prototype for 'kasan_shallow_populate' [-Wmissing-prototypes]
161 | void __init kasan_shallow_populate(void *start, void *end)
| ^~~~~~~~~~~~~~~~~~~~~~


vim +/kasan_shallow_populate_pgd +146 arch/riscv/mm/kasan_init.c

145
> 146 void __init kasan_shallow_populate_pgd(unsigned long vaddr, unsigned long end)
147 {
148 unsigned long next;
149 void *p;
150 pgd_t *pgd_k = pgd_offset_k(vaddr);
151
152 do {
153 next = pgd_addr_end(vaddr, end);
154 if (pgd_page_vaddr(*pgd_k) == (unsigned long)lm_alias(kasan_early_shadow_pmd)) {
155 p = memblock_alloc(PAGE_SIZE, PAGE_SIZE);
156 set_pgd(pgd_k, pfn_pgd(PFN_DOWN(__pa(p)), PAGE_TABLE));
157 }
158 } while (pgd_k++, vaddr = next, vaddr != end);
159 }
160

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip