RE: Re: [PATCH v24 1/4] scsi: ufs: Introduce HPB feature

From: Daejun Park
Date: Thu Feb 25 2021 - 23:51:06 EST


> >
> > +void ufshpb_init(struct ufs_hba *hba)
> > +{
> > + struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> > + int try;
> > + int ret;
> > +
> > + if (!ufshpb_is_allowed(hba))
> > + return;
> > +
>
> Here it is better to check "dev_info->hpb_enable", if HPB is not
> enabled from UFS device level, doesn't need to create mempool and take
> other memory resource.

I will add checking dev_info->hpb_enable value.
if (!ufshpb_is_allowed(hba) || !dev_info->hpb_enable)

Thanks,
Daejun

> Bean
>
>
>
>
>
>