Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing

From: Bjorn Helgaas
Date: Thu Feb 25 2021 - 13:52:18 EST


On Thu, Feb 25, 2021 at 09:44:12AM -0800, Kuppuswamy, Sathyanarayanan wrote:
> On 2/25/21 6:37 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > Compile-testing these drivers is currently broken. Enabling
> > it causes a couple of build failures though:
> >
> > drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> > drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration]
> > drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration]
> >
> > Fix them with the obvious one-line changes.
> Looks good to me.

Thanks for looking this over! I'd like to acknowledge your review,
but I need an explicit Reviewed-by or similar. I don't want to put
words in your mouth by converting "Looks good to me" to "Reviewed-by".