Re: [PATCH] kallsyms: make arch_get_kallsym static

From: kernel test robot
Date: Thu Feb 25 2021 - 05:44:42 EST


Hi Jiapeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11 next-20210225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Jiapeng-Chong/kallsyms-make-arch_get_kallsym-static/20210225-151617
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 29c395c77a9a514c5857c45ceae2665e9bd99ac7
config: powerpc64-randconfig-r034-20210225 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a921aaf789912d981cbb2036bdc91ad7289e1523)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/a7d1bbc523397eaea74cc12deaf0de6a73ce105b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jiapeng-Chong/kallsyms-make-arch_get_kallsym-static/20210225-151617
git checkout a7d1bbc523397eaea74cc12deaf0de6a73ce105b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> kernel/kallsyms.c:457:12: error: weak declaration cannot have internal linkage
static int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
^
include/linux/compiler_attributes.h:291:56: note: expanded from macro '__weak'
#define __weak __attribute__((__weak__))
^
1 error generated.


vim +457 kernel/kallsyms.c

456
> 457 static int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
458 char *type, char *name)
459 {
460 return -EINVAL;
461 }
462

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip