Re: [PATCH v2 0/2] leds: bcm63x8: improve read and write functions

From: Álvaro Fernández Rojas
Date: Wed Feb 24 2021 - 11:08:56 EST


Hi Florian,

> El 24 feb 2021, a las 16:45, Florian Fainelli <f.fainelli@xxxxxxxxx> escribió:
>
>
>
> On 2/24/2021 2:11 AM, Álvaro Fernández Rojas wrote:
>> This code is proven to work in BMIPS BE/LE and ARM BE/LE.
>> See bcm2835-rng and bcmgenet.c:
>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
>> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
>
> What is the motivation for doing this? bcm2835-rng and bcmgenet are used
> across MIPS and ARM platforms therefore they need to be compatible with
> both, but these two LEDs drivers are super specialized, are you working
> on porting the 6328 LED driver to the newer ARM-based DSL SoCs such as
> 63138 and 63148?

I just wanted to have all bmips drivers in line (at least regarding read/write).
If I remember correctly someone told me that this controller was also present on some little endian SoCs, but you can confirm that :).
Unfortunately I haven’t got any devices with ARM-based DSL SoCs, so the answer is no.

> --
> Florian

Best regards,
Álvaro.