Re: [PATCH v6 0/3] mm,thp,shm: limit shmem THP alloc gfp_mask

From: Rik van Riel
Date: Wed Feb 24 2021 - 10:35:03 EST


On Wed, 2021-02-24 at 00:41 -0800, Hugh Dickins wrote:
> On Mon, 14 Dec 2020, Vlastimil Babka wrote:
>
> > > (There's also a specific issue with the gfp_mask limiting: I have
> > > not yet reviewed the allowing and denying in detail, but it looks
> > > like it does not respect the caller's GFP_ZONEMASK - the gfp in
> > > shmem_getpage_gfp() and shmem_read_mapping_page_gfp() is there to
> > > satisfy the gma500, which wanted to use shmem but could only
> manage
> > > DMA32. I doubt it wants THPS, but shmem_enabled=force forces
> them.)
>
> Oh, I'd forgotten all about that gma500 aspect:
> well, I can send a fixup later on.

I already have code to fix that, which somebody earlier
in this discussion convinced me to throw away. Want me
to send it as a patch 4/3 ?

--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part