Re: [PATCH] ath11k: qmi: use %pad to format dma_addr_t

From: Kalle Valo
Date: Wed Feb 24 2021 - 01:39:25 EST


Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> If CONFIG_ARCH_DMA_ADDR_T_64BIT=n:
>
> drivers/net/wireless/ath/ath11k/qmi.c: In function ‘ath11k_qmi_respond_fw_mem_request’:
> drivers/net/wireless/ath/ath11k/qmi.c:1690:8: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘dma_addr_t’ {aka ‘unsigned int’} [-Wformat=]
> 1690 | "qmi req mem_seg[%d] 0x%llx %u %u\n", i,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1691 | ab->qmi.target_mem[i].paddr,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | dma_addr_t {aka unsigned int}
> drivers/net/wireless/ath/ath11k/debug.h:64:30: note: in definition of macro ‘ath11k_dbg’
> 64 | __ath11k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__); \
> | ^~~
> drivers/net/wireless/ath/ath11k/qmi.c:1690:34: note: format string is defined here
> 1690 | "qmi req mem_seg[%d] 0x%llx %u %u\n", i,
> | ~~~^
> | |
> | long long unsigned int
> | %x
>
> Fixes: d5395a5486596308 ("ath11k: qmi: add debug message for allocated memory segment addresses and sizes")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Patch applied to wireless-drivers.git, thanks.

ebb9d34e073d ath11k: qmi: use %pad to format dma_addr_t

--
https://patchwork.kernel.org/project/linux-wireless/patch/20210221182754.2071863-1-geert@xxxxxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches