Re: [PATCH] sched/fair: Fix task utilization accountability in cpu_util_next()

From: Dietmar Eggemann
Date: Tue Feb 23 2021 - 09:46:32 EST


On 22/02/2021 10:54, vincent.donnefort@xxxxxxx wrote:
> From: Vincent Donnefort <vincent.donnefort@xxxxxxx>

[...]

> Also, replace sub_positive with lsub_positive which saves one explicit
> load-store.

IMHO, in case you're going to fix this now in compute_energy(), this
optimization could still be done. Maybe in an extra patch?
cpu_util_without() is using lsub_positive() to remove task util from cpu
util as well.

[...]