Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

From: Avi Fishman
Date: Tue Feb 23 2021 - 08:15:27 EST


Hi Anton,

At runtime do you get into the code inside npcmx50_sdhci.c, but it
doesn't work well or not access at all?
Can you check those registers (BootBlock should set them for you):
sd1irv1 at address 0xf0800054 value = 0xf5c80f80
sd1irv2 at address 0xf0800058 value = 0x52001132
sd2irv1 at address 0xf08000b4 value = 0xfdc80f80
sd2irv2 at address 0xf08000b8 value = 0x52003132

Also try to use attached file.

Thanks,
Avi

On Mon, Feb 22, 2021 at 4:25 PM Anton Kachalov <gmouse@xxxxxxxxxx> wrote:
>
> Ofer,
>
> The oldest version from igps doesn't work as well as the latest
> version from u-boot github.
>
> The only version that works for me is in software deliverables:
>
> https://github.com/Nuvoton-Israel/nuvoton-info/tree/master/npcm7xx-poleg/evaluation-board/sw_deliverables/npcm7xx_v2.3
>
> On Mon, 22 Feb 2021 at 15:10, IS20 Ofer Eilon <ofer.eilon@xxxxxxxxxxx> wrote:
> >
> > Hi Avi,
> >
> > It seems an old version of uboot u-boot_2019.01.7.5.bin from igps below:
> >
> > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fversions&amp;data=04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=0%2BNzEv%2FSX9QTg0XumchRrU61uGbZ3CZXrtspXu2560I%3D&amp;reserved=0
> >
> > Please use latest from uboot.bin github.
> >
> > Regards,
> > Ofer
> >
> >
> > -----Original Message-----
> > From: Avi Fishman <avifishman70@xxxxxxxxx>
> > Sent: Monday, February 22, 2021 12:21 PM
> > To: Anton Kachalov <gmouse@xxxxxxxxxx>
> > Cc: Tomer Maimon <tmaimon77@xxxxxxxxx>; Benjamin Fair <benjaminfair@xxxxxxxxxx>; Tali Perry <tali.perry1@xxxxxxxxx>; Patrick Venture <venture@xxxxxxxxxx>; Nancy Yuen <yuenn@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; OpenBMC Maillist <openbmc@xxxxxxxxxxxxxxxx>; devicetree <devicetree@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; IS20 Ofer Eilon <ofer.eilon@xxxxxxxxxxx>
> > Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout
> >
> > Ofer,
> >
> > Can you check why u-boot doesn't work with SD cards?
> >
> > On Mon, Feb 22, 2021 at 11:27 AM Anton Kachalov <gmouse@xxxxxxxxxx> wrote:
> > >
> > > Hi, Tom.
> > >
> > > Yes, I'm using it for testing on real hardware.
> > >
> > > BTW. Recent u-boot doesn't work with SD cards. The card doesn't
> > > detect. The last working version was this one:
> > >
> > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > > ub.com%2FNuvoton-Israel%2Fnuvoton-info%2Ftree%2Fmaster%2Fnpcm7xx-poleg
> > > %2Fevaluation-board%2Fsw_deliverables%2Fnpcm7xx_v2.3&amp;data=04%7C01%
> > > 7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f249
> > > 31d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTW
> > > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> > > Mn0%3D%7C1000&amp;sdata=f4t41g3CQaFTQNfwwNVBrIwQScndIGcfRTms0yrTn5o%3D
> > > &amp;reserved=0
> > >
> > > However, u-boot from igps repo:
> > >
> > > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > > ub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fver
> > > sions&amp;data=04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee
> > > 4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C6374958611
> > > 62860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> > > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=0%2BNzEv%2FSX9QTg0Xumch
> > > RrU61uGbZ3CZXrtspXu2560I%3D&amp;reserved=0
> > >
> > > Has issues too. It doesn't allow me to read more than 4k bytes once at
> > > a time. Thus, to flash the stuff I have manually read chunks from the
> > > SD-card: fat load doesn't work at all and I write that data in raw
> > > partition.
> > >
> > > On Sun, 21 Feb 2021 at 17:40, Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
> > > >
> > > > Hi Benjamin and Anton,
> > > >
> > > > Sorry for the late reply,
> > > >
> > > > The EVB FIU0-CS0 partitioning is used for testing the EVB and this is why it is different than the OpenBMC flash layout.
> > > >
> > > >
> > > >
> > > > Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to modify the flash partition to OpenBMC use.
> > > >
> > > >
> > > > On Thu, 18 Feb 2021 at 19:11, Benjamin Fair <benjaminfair@xxxxxxxxxx> wrote:
> > > >>
> > > >> On Thu, 18 Feb 2021 at 04:42, <gmouse@xxxxxxxxxx> wrote:
> > > >> >
> > > >> > From: "Anton D. Kachalov" <gmouse@xxxxxxxxxx>
> > > >> >
> > > >> > This change satisfy OpenBMC requirements for flash layout.
> > > >> >
> > > >> > Signed-off-by: Anton D. Kachalov <gmouse@xxxxxxxxxx>
> > > >> > ---
> > > >> > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28
> > > >> > +++++++----------------
> > > >> > 1 file changed, 8 insertions(+), 20 deletions(-)
> > > >> >
> > > >> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > > >> > b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > > >> > index bd1eb6ee380f..741c1fee8552 100644
> > > >> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > > >> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > > >> > @@ -182,8 +182,8 @@ bbuboot2@80000 {
> > > >> > reg = <0x0080000 0x80000>;
> > > >> > read-only;
> > > >> > };
> > > >> > - envparam@100000 {
> > > >> > - label = "env-param";
> > > >> > + ubootenv@100000 {
> > > >> > + label = "u-boot-env";
> > > >> > reg = <0x0100000 0x40000>;
> > > >> > read-only;
> > > >> > }; @@ -195,25 +195,13 @@
> > > >> > kernel@200000 {
> > > >> > label = "kernel";
> > > >> > reg = <0x0200000 0x400000>;
> > > >> > };
> > > >> > - rootfs@600000 {
> > > >> > - label = "rootfs";
> > > >> > - reg = <0x0600000 0x700000>;
> > > >> > + rofs@780000 {
> > > >> > + label = "rofs";
> > > >> > + reg = <0x0780000 0x1680000>;
> > > >> > };
> > > >> > - spare1@D00000 {
> > > >> > - label = "spare1";
> > > >> > - reg = <0x0D00000 0x200000>;
> > > >> > - };
> > > >> > - spare2@0F00000 {
> > > >> > - label = "spare2";
> > > >> > - reg = <0x0F00000 0x200000>;
> > > >> > - };
> > > >> > - spare3@1100000 {
> > > >> > - label = "spare3";
> > > >> > - reg = <0x1100000 0x200000>;
> > > >> > - };
> > > >> > - spare4@1300000 {
> > > >> > - label = "spare4";
> > > >> > - reg = <0x1300000 0x0>;
> > > >> > + rwfs@1e00000 {
> > > >> > + label = "rwfs";
> > > >> > + reg = <0x1e00000 0x200000>;
> > > >> > };
> > > >>
> > > >> I recommend just including the openbmc-flash-layout.dtsi file here
> > > >> instead since that contains the common flash layout for most
> > > >> OpenBMC systems.
> > > >>
> > > > Good solution,
> > > > Do you mean nuvoton-openbmc-flash-layout?
> > > >>
> > > >> > };
> > > >> > };
> > > >> > --
> > > >> > 2.30.0.478.g8a0d178c01-goog
> > > >> >
> > > >
> > > >
> > > > Thanks,
> > > >
> > > > Tomer
> >
> >
> >
> > --
> > Regards,
> > Avi
> > ________________________________
> > ________________________________
> > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.



--
Regards,
Avi

Attachment: npcmx50_sdhci.c
Description: Binary data