arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration

From: kernel test robot
Date: Mon Feb 22 2021 - 02:21:32 EST


tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 31caf8b2a847214be856f843e251fc2ed2cd1075
commit: 9f0b4807a44ff81cf59421c8a86641efec586610 um: rework userspace stubs to not hard-code stub location
date: 9 days ago
config: um-i386_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f0b4807a44ff81cf59421c8a86641efec586610
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 9f0b4807a44ff81cf59421c8a86641efec586610
# save the attached .config to linux build tree
make W=1 ARCH=um SUBARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

In file included from arch/x86/um/shared/sysdep/stub.h:9,
from arch/um/kernel/skas/clone.c:14:
>> arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
80 | static void inline remap_stack_and_trap(void)
| ^~~~~~
--
In file included from arch/x86/um/shared/sysdep/stub.h:9,
from arch/um/os-Linux/skas/process.c:23:
>> arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
80 | static void inline remap_stack_and_trap(void)
| ^~~~~~
arch/um/os-Linux/skas/process.c:106:6: warning: no previous prototype for 'wait_stub_done' [-Wmissing-prototypes]
106 | void wait_stub_done(int pid)
| ^~~~~~~~~~~~~~
arch/um/os-Linux/skas/process.c:720:6: warning: no previous prototype for '__switch_mm' [-Wmissing-prototypes]
720 | void __switch_mm(struct mm_id *mm_idp)
| ^~~~~~~~~~~


vim +/inline +80 arch/x86/um/shared/sysdep/stub_32.h

79
> 80 static void inline remap_stack_and_trap(void)
81 {
82 __asm__ volatile (
83 "movl %%esp,%%ebx ;"
84 "andl %0,%%ebx ;"
85 "movl %1,%%eax ;"
86 "movl %%ebx,%%edi ; addl %2,%%edi ; movl (%%edi),%%edi ;"
87 "movl %%ebx,%%ebp ; addl %3,%%ebp ; movl (%%ebp),%%ebp ;"
88 "int $0x80 ;"
89 "addl %4,%%ebx ; movl %%eax, (%%ebx) ;"
90 "int $3"
91 : :
92 "g" (~(UM_KERN_PAGE_SIZE - 1)),
93 "g" (STUB_MMAP_NR),
94 "g" (UML_STUB_FIELD_FD),
95 "g" (UML_STUB_FIELD_OFFSET),
96 "g" (UML_STUB_FIELD_CHILD_ERR),
97 "c" (UM_KERN_PAGE_SIZE),
98 "d" (PROT_READ | PROT_WRITE),
99 "S" (MAP_FIXED | MAP_SHARED)
100 :
101 "memory");
102 }
103

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip