Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic

From: Florian Fainelli
Date: Mon Feb 22 2021 - 00:06:59 EST




On 2/21/2021 17:35, Sieng Piaw Liew wrote:
In ndo_stop functions, netdev_completed_queue() is called during forced
tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
there is any tx skb left.

This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
complete successfully then reset.

Signed-off-by: Sieng Piaw Liew <liew.s.piaw@xxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support")
--
Florian