Re: [RFC v1 09/26] x86/tdx: Handle CPUID via #VE

From: Dave Hansen
Date: Sun Feb 07 2021 - 17:32:27 EST


On 2/7/21 12:29 PM, Kirill A. Shutemov wrote:
>> Couldn't you just have one big helper that takes *all* the registers
>> that get used in any TDVMCALL and sets all the rcx bits? The users
>> could just pass 0's for the things they don't use.
>>
>> Then you've got the ugly inline asm in one place. It also makes it
>> harder to screw up the 'rcx' mask and end up passing registers you
>> didn't want into a malicious VMM.
> For now we only pass down R10-R15, but the interface allows to pass down
> much wider set of registers, including XMM. How far do we want to get it?

Just do what we immediately need: R10-R15.