Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

From: Kumar Kartikeya Dwivedi
Date: Sun Feb 07 2021 - 02:39:50 EST


On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote:
>
> Given that drivers/staging/emxx_udc/emxx_udc.h is only included by
> drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be
> declared static in emxx_udc.c and removed from emxx_udc.h?
>

Either would be correct. I went this way because it was originally trying to
(incorrectly) define a global variable instead. I guess they can be static now
and when more users are added, the linkage can be adjusted as needed.

Here's another version of the patch:

--