Re: [PATCH] Revert "ACPICA: Interpreter: fix memory leak by using existing buffer"

From: Shawn Guo
Date: Sat Feb 06 2021 - 05:51:11 EST


On Sat, Feb 06, 2021 at 09:49:37AM +0100, Ard Biesheuvel wrote:
> This reverts commit 32cf1a12cad43358e47dac8014379c2f33dfbed4.
>
> The 'exisitng buffer' in this case is the firmware provided table, and
> we should not modify that in place. This fixes a crash on arm64 with
> initrd table overrides, in which case the DSDT is not mapped with
> read/write permissions.
>
> Cc: Robert Moore <robert.moore@xxxxxxxxx>
> Cc: Erik Kaneda <erik.kaneda@xxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Reported-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

Tested-by: Shawn Guo <shawn.guo@xxxxxxxxxx>

Thanks for fixing the regression, Ard!

Shawn