Re: [RFC PATCH 6/8] preempt/dynamic: Provide preempt_schedule[_notrace]() static calls

From: Peter Zijlstra
Date: Sat Feb 06 2021 - 04:12:02 EST


On Fri, Feb 05, 2021 at 08:31:22PM -0600, Josh Poimboeuf wrote:
> On Fri, Feb 05, 2021 at 04:30:56PM +0100, Peter Zijlstra wrote:
> > On Wed, Feb 03, 2021 at 03:04:23PM +0100, Peter Zijlstra wrote:
> > > Fair enough I suppose. I'll slap a changelog and your SoB on it and I
> > > suppose I'll got commit the whole lot. Then we can forget about it
> > > again.
> >
> > FWIW, the whole thing looks like this..
> >
> > ---
> > Subject: static_call: Allow module use without exposing static_call_key
> > From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > Date: Wed, 27 Jan 2021 17:18:37 -0600
> >
> > From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> >
> > When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module
> > can use static_call_update() to change the function called. This is
> > not desirable in general.
>
> Looks good to me, thanks for fixing that up. Never said I tested it ;-)

Yeah, and I'm the genius that 'tested' it with a MODULES=n build :-)