Re: [PATCH v3] mfd: da9063: Support SMBus and I2C mode

[Wolfram Sang]

> +	if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) {
> +		dev_info(da9063->dev, "I2C mode");
> +		busmode = 0;
> +	} else {
> +		dev_info(da9063->dev, "SMBus mode");
> +		busmode = DA9063_TWOWIRE_TO;
> +	}

In principle, this looks good and is sane to do. I'd just suggest to
leave out the dev_info calls and maybe just do:

	busmode = i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C) ?
		  0 : DA9063_TWOWIRE_TO;

Attachment: signature.asc
Description: PGP signature