Re: [PATCH] kunit: tool: simplify kconfig is_subset_of() logic

From: Brendan Higgins
Date: Fri Feb 05 2021 - 22:02:21 EST


On Tue, Dec 8, 2020 at 3:21 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
>
> Don't use an O(nm) algorithm* and make it more readable by using a dict.
>
> *Most obviously, it does a nested for-loop over the entire other config.
> A bit more subtle, it calls .entries(), which constructs a set from the
> list for _every_ outer iteration.
>
> Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>

Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Acked-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>