Re: [PATCH] drivers: mtd: Better word replace a not so good word in the file mtd_blkdevs.c

From: Bhaskar Chowdhury
Date: Fri Feb 05 2021 - 18:54:54 EST


On 14:57 Fri 05 Feb 2021, Miquel Raynal wrote:
Hi Bhaskar,

Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> wrote on Fri, 5 Feb 2021
19:06:39 +0530:

On 14:26 Fri 05 Feb 2021, Miquel Raynal wrote:
>Hi Bhaskar,
>
>Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> wrote on Fri, 5 Feb 2021
>18:11:51 +0530:
>
>> s/fucking/invite/
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
>> ---
>> drivers/mtd/mtd_blkdevs.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
>> index fb8e12d590a1..756a0995e474 100644
>> --- a/drivers/mtd/mtd_blkdevs.c
>> +++ b/drivers/mtd/mtd_blkdevs.c
>> @@ -523,7 +523,7 @@ int register_mtd_blktrans(struct mtd_blktrans_ops *t
r)
>> int ret;
>>
>> /* Register the notifier if/when the first device type is
>> - registered, to prevent the link/init ordering from fucking
>> + registered, to prevent the link/init ordering from invite
>> us over. */
>
>invite us over?
>
>I'm not a native English speaker but this does not bring any value to
>my ears. Worse, I don't even get the point. Better rewrite the comment
>entirely than just swapping "fucking" with a random word, no?
>
Got your point , and I do understand "fuck" and "fucking" is so strong word
that it is really difficult to replace with something else.

But..but you suggestion to rewrite the comments sounds good Miquel ...wish I
could have that much time in hand to replace every sentence having that word
...all the patched sent with that word replaces...please step forward and
make
and send patches .

Today I sent 10 patches replacing that word(weather that make sense or not)
you can see those in the ML ...please pick up as you wish and send patches.

There are currently 21 uses of "fuck[ing]". It's not a mountain to
climb. Nor a race.

✔ ~/git-linux/linux [master|✔]
19:28 $ search fuck | wc -l
15

I was simply replacing the word ..never bother about the meaning it
conveys..doesn't matter really.

Are you kidding? What is the purpose of a comment if no one understands
it after a blind change?

No I am not . But the sentences contains that word hardly have more meaning. But as you already said rewriting those comment would be a good idea...can you take up some of those??


so...

Attachment: signature.asc
Description: PGP signature