Re: [PATCH 5/8] spi: stm32: defer probe for reset

From: Mark Brown
Date: Fri Feb 05 2021 - 15:38:46 EST


On Fri, Feb 05, 2021 at 12:08:59PM +0100, Alain Volmat wrote:
> Defer the probe operation when a reset controller device is expected
> but have not yet been probed.
>
> This change replaces use of devm_reset_control_get_exclusive() with
> devm_reset_control_get_optional_exclusive() as reset controller is
> optional which is now explicitly stated.

This has trouble building an x86 allmodconfig build:

/mnt/kernel/drivers/spi/spi-stm32.c: In function 'stm32_spi_prepare_msg':
/mnt/kernel/drivers/spi/spi-stm32.c:1022:9: error: 'STM32H7_SPI_TSIZE_MAX' undeclared (first use in this function); did you mean 'STM32H7_SPI_CR1_MASRX'?
STM32H7_SPI_TSIZE_MAX,
^~~~~~~~~~~~~~~~~~~~~
STM32H7_SPI_CR1_MASRX
/mnt/kernel/drivers/spi/spi-stm32.c:1022:9: note: each undeclared identifier is reported only once for each function it appears in

This may be due to an earlier patch in the series, my script is working
back through the patch series.

Attachment: signature.asc
Description: PGP signature