Re: [PATCH 2/2] platform/chrome: cros_ec_types: Support disconnect events without partners

From: Prashant Malani
Date: Fri Feb 05 2021 - 15:07:50 EST


Hi Raj,

On Fri, Feb 5, 2021 at 11:52 AM Rajmohan Mani <rajmohan.mani@xxxxxxxxx> wrote:
>
> There are certain scenarios, where a disconnect event might
> occur on a Type-C port with no port partners. This is required
> to enable communication to Burnside Bridge USB4 retimers.
>
> Signed-off-by: Rajmohan Mani <rajmohan.mani@xxxxxxxxx>
minor commit message nit (apologies for not spotting this earlier):

This patch alone doesn't add support for the "without partners" part
(that comes in the next patch).
This one purely adds support for disconnect events. So might be good
to update the commit message if possible.
But otherwise LGTM, so:

Reviewed-by: Prashant Malani <pmalani@xxxxxxxxxxxx>