Re: [patch 01/12] x86/entry: Fix instrumentation annotation

From: Borislav Petkov
Date: Fri Feb 05 2021 - 07:07:53 EST


On Thu, Feb 04, 2021 at 09:49:04PM +0100, Thomas Gleixner wrote:
> Embracing a callout into instrumentation_begin() / instrumentation_begin()
> does not really make sense. Make the latter instrumentation_end().
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
> arch/x86/entry/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/entry/common.c
> +++ b/arch/x86/entry/common.c
> @@ -270,7 +270,7 @@ static void __xen_pv_evtchn_do_upcall(vo
>
> instrumentation_begin();
> run_on_irqstack_cond(__xen_pv_evtchn_do_upcall, regs);
> - instrumentation_begin();
> + instrumentation_end();
>
> set_irq_regs(old_regs);

Cc: <stable@xxxxxxxxxxxxxxx> ?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette