Re: [dm-devel] [PATCH AUTOSEL 5.4 03/26] dm integrity: select CRYPTO_SKCIPHER

[Sasha Levin]

On Tue, Jan 19, 2021 at 09:47:31PM -0800, Eric Biggers wrote:
> On Tue, Jan 19, 2021 at 08:26:40PM -0500, Sasha Levin wrote:
> > From: Anthony Iliopoulos <ailiop@xxxxxxxx>
> >
> > [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ]
> >
> > The integrity target relies on skcipher for encryption/decryption, but
> > certain kernel configurations may not enable CRYPTO_SKCIPHER, leading to
> > compilation errors due to unresolved symbols. Explicitly select
> > CRYPTO_SKCIPHER for DM_INTEGRITY, since it is unconditionally dependent
> > on it.
> >
> > Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx>
> > Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/md/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> > index aa98953f4462e..7dd6e98257c72 100644
> > --- a/drivers/md/Kconfig
> > +++ b/drivers/md/Kconfig
> > @@ -565,6 +565,7 @@ config DM_INTEGRITY
> >  	select BLK_DEV_INTEGRITY
> >  	select DM_BUFIO
> >  	select CRYPTO
> > +	select CRYPTO_SKCIPHER
> >  	select ASYNC_XOR
> >  	---help---
> >  	  This device-mapper target emulates a block device that has
>
> CRYPTO_SKCIPHER doesn't exist in 5.4 and earlier because it was renamed from
> CRYPTO_BLKCIPHER in 5.5.  If this patch is really important enough to backport,
> CRYPTO_SKCIPHER will need to be changed to CRYPTO_BLKCIPHER.

I'll just drop it, thanks!

--
Thanks,
Sasha