Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

From: Steven Rostedt
Date: Thu Feb 04 2021 - 17:06:21 EST


On Thu, 4 Feb 2021 22:49:44 +0100
Pavel Machek <pavel@xxxxxx> wrote:

> This machine is insecure. Yet I don't see ascii-art *** all around..
>
> "Kernel memory addresses are exposed, which is bad for security."
> would be quite enough, I'd say...

Well, the alternative is that you go back to patching your own kernel, and
we drop this patch altogether.

The compromise was to add this notice, to make sure that this doesn't get
set normally.

Changing the wording is fine, but to keep the option from being "forgotten
about" by a indiscrete message isn't going to fly.

-- Steve