Re: [PATCH 13/14] cxl/mem: Add limited Get Log command (0401h)

From: Dan Williams
Date: Thu Feb 04 2021 - 16:02:32 EST


On Thu, Feb 4, 2021 at 10:56 AM Ben Widawsky <ben.widawsky@xxxxxxxxx> wrote:
[..]
> It actually got pushed into cxl_mem_raw_command_allowed()
>
> static bool cxl_mem_raw_command_allowed(u16 opcode)
> {
> int i;
>
> if (!IS_ENABLED(CONFIG_CXL_MEM_RAW_COMMANDS))
> return false;
>
> if (security_locked_down(LOCKDOWN_NONE))
> return false;
>
> if (raw_allow_all)
> return true;
>
> if (is_security_command(opcode))
> return false;
>
> for (i = 0; i < ARRAY_SIZE(disabled_raw_commands); i++)
> if (disabled_raw_commands[i] == opcode)
> return false;
>
> return true;
> }
>
> That work for you?

Looks good to me.