Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

[Lee Jones]

On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote:

> On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> > 
> >  drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead
> >  drivers/crypto/keembay/ocs-hcu.c:127: warning: expecting prototype for struct ocs_dma_list. Prototype was for struct ocs_hcu_dma_list instead
> >  drivers/crypto/keembay/ocs-hcu.c:610: warning: expecting prototype for ocs_hcu_digest(). Prototype was for ocs_hcu_hash_update() instead
> >  drivers/crypto/keembay/ocs-hcu.c:648: warning: expecting prototype for ocs_hcu_hash_final(). Prototype was for ocs_hcu_hash_finup() instead
> > 
> > Cc: Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx>
> > Cc: Declan Murphy <declan.murphy@xxxxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: linux-crypto@xxxxxxxxxxxxxxx
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> 
> Acked-by: Daniele Alessandrelli <daniele.alessandrelli@xxxxxxxxx>
> 
> 
> Thanks for fixing these.
> 
> For some reason, if the issues are there, I don't get those warnings
> when compiling with W=1; the command I run is:
> 
>    make CROSS_COMPILE=<arm-compiler> ARCH=arm64 -j5 W=4 M=drivers/crypto/keembay

Not sure what would happen with 'W=4'.

Probably nothing, as it only goes up to 3 [0].

> Which command are you running exactly? I'll use it for my next
> submissions.

 rm -rf ../builds/build-arm64/drivers/crypto/
 make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64 allmodconfig
 make -f Makefile -j24 --quiet ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- KBUILD_OUTPUT=../builds/build-arm64  W=1 drivers/crypto/

Hope that helps.

[0] scripts/Makefile.extrawarn

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog