Re: [PATCH 07/12] KVM: x86: SEV: Treat C-bit as legal GPA bit regardless of vCPU mode

From: Paolo Bonzini
Date: Thu Feb 04 2021 - 12:59:25 EST


On 04/02/21 18:52, Sean Christopherson wrote:
Alternatively there could be something like a is_rsvd_cr3_bits() helper that
just uses reserved_gpa_bits for now. Probably put the comment in the wrong
place. It's a minor point in any case.
That thought crossed my mind, too. Maybe kvm_vcpu_is_illegal_cr3() to match
the gpa helpers?

Yes, that's certainly a good name but it doesn't have to be done now. Or at least, if you do it, somebody is guaranteed to send a patch after one month because the wrapper is useless. :)

Paolo