Re: [PATCH v7 1/4] crypto: Add support for ECDSA signature verification

From: Jarkko Sakkinen
Date: Thu Feb 04 2021 - 10:07:54 EST


On Thu, Feb 04, 2021 at 04:27:39PM +1100, Herbert Xu wrote:
> On Mon, Feb 01, 2021 at 10:19:07AM -0500, Stefan Berger wrote:
> > Add support for parsing the parameters of a NIST P256 or NIST P192 key.
> > Enable signature verification using these keys. The new module is
> > enabled with CONFIG_ECDSA:
> > Elliptic Curve Digital Signature Algorithm (NIST P192, P256 etc.)
> > is A NIST cryptographic standard algorithm. Only signature verification
> > is implemented.
> >
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: linux-crypto@xxxxxxxxxxxxxxx
> > ---
> > crypto/Kconfig | 10 +
> > crypto/Makefile | 6 +
> > crypto/ecc.c | 13 +-
> > crypto/ecc.h | 28 +++
> > crypto/ecdsa.c | 361 +++++++++++++++++++++++++++++++++++
> > crypto/ecdsasignature.asn1 | 4 +
> > crypto/testmgr.c | 12 ++
> > crypto/testmgr.h | 267 ++++++++++++++++++++++++++
> > include/linux/oid_registry.h | 4 +
> > 9 files changed, 694 insertions(+), 11 deletions(-)
> > create mode 100644 crypto/ecdsa.c
> > create mode 100644 crypto/ecdsasignature.asn1


Acked-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

Great, ECDSA has been lacking for a way too long. Just wanted to
acknowledge support for this, I just now also skimmed the change
from patchwrok (way too quickly for reviewed-by but well enough
for ack).

/Jarkko