Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes

From: Bartosz Golaszewski
Date: Thu Feb 04 2021 - 07:38:52 EST


On Mon, Jan 11, 2021 at 3:08 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> We no longer need to undef pr_fmt if we define our own before including
> any headers.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
> drivers/clocksource/timer-davinci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
> index bb4eee31ae08..9996c0542520 100644
> --- a/drivers/clocksource/timer-davinci.c
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -7,6 +7,8 @@
> * (with tiny parts adopted from code by Kevin Hilman <khilman@xxxxxxxxxxxx>)
> */
>
> +#define pr_fmt(fmt) "%s: " fmt, __func__
> +
> #include <linux/clk.h>
> #include <linux/clockchips.h>
> #include <linux/interrupt.h>
> @@ -17,9 +19,6 @@
>
> #include <clocksource/timer-davinci.h>
>
> -#undef pr_fmt
> -#define pr_fmt(fmt) "%s: " fmt, __func__
> -
> #define DAVINCI_TIMER_REG_TIM12 0x10
> #define DAVINCI_TIMER_REG_TIM34 0x14
> #define DAVINCI_TIMER_REG_PRD12 0x18
> --
> 2.29.1
>

Gentle ping.

Bart