Re: [PATCH] add chan->cl check in mbox_chan_received_data()

[Yao Haidong]

 Oh, I see, thank you

2021-02-01 14:28 GMT+08:00, Jassi Brar <jassisinghbrar@xxxxxxxxx>:
> On Thu, Jan 7, 2021 at 5:53 AM haidong yao <yaohaidong369@xxxxxxxxx> wrote:
>>
>> Hi Jassi Brar
>>
>> Thank you very much for your reply.
>>
>> Look at the function sprd_mbox_outbox_isr .
>>
>> Chan is !NULL.
>>
>> chan->cl is NULL when the client driver not loaded, the controller
>> driver don't know the client driver loaded successfully, so, I do not
>> use mbox_free_channel.
>>
>> Here,How do you know chan->cl is ok?
>>
> The channel is supposed to get/send data _only_ if it is being used by a
> client.
> Which you can mark in .startup() and .shutdown().
>
> Checking for chan->cl will make your symptoms disappear but that is
> not the right fix for the issue.
> The right fix is to EITHER not cause Rx/Tx interrupt on a channel not
> being used, OR not send it to upper layers.
>
> thanks.
>